Favicon format - Githubissues

Onehot-NL / onehot.nl

Code for our data science meetup

0 stars 0 forks source link

Favicon format #8

Closed duijf closed 3 years ago

duijf commented 3 years ago

The current favicon is an SVG file with a :speech_balloon: emoji. I really like the speech balloon as a favicon, but we might want to serve it as a .png or .ico file instead.

Reasons:

The rendering of the icon currently isn't consistent between systems / browsers. (It depends on what font is being used by the user).
The xmlns attribute of the <svg> element is causing warnings in the console due to the CSP in production. (Ticket to improve this so we can also find out in local development: #7)

RCdeWit commented 3 years ago

Agree that this would be a good idea. We would have to settle for a specific font, however.

Favicon.io provides a convient download. If we're okay with a slightly blueish hue, we can settle for that one.

duijf commented 3 years ago

Sounds good to me!

duijf commented 3 years ago

Found a potential alternative: Google's Noto font is free to use and has a speech bubble emoji that looks really nice to me.

You can view it on this page if you search for "Speech Balloon"

duijf commented 3 years ago

Added a new favicon in https://github.com/duijf/onehot/commit/582e326a0226c57dab186c7ca66c9cf31e193232

Feel free to reopen if you don't like it!

RCdeWit commented 3 years ago

Looks very nice, I much prefer it to the blueish one I linked above.