Oneirocom / Magick

Magick is a cutting-edge toolkit for a new kind of AI builder. Make Magick with us!
https://magickml.com
Other
705 stars 115 forks source link

re-organized node picker menu #1448

Closed FabriceIRANKUNDA closed 9 months ago

FabriceIRANKUNDA commented 10 months ago

What Changed:

Improved node picker

How to test:

How can the reviewer test your changes and validate that they work as described?

Additional information:

Any other information that might be useful while reviewing.

vercel[bot] commented 10 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
magick-client ❌ Failed (Inspect) Jan 31, 2024 0:02am
magick-docs ❌ Failed (Inspect) Jan 31, 2024 0:02am
FabriceIRANKUNDA commented 10 months ago

https://github.com/Oneirocom/Magick/assets/58092199/33ac7fe4-9d9f-4ce0-b1ed-02c484a141a1

michaelsharpe commented 10 months ago

@FabriceIRANKUNDA this looks great!

One change I would make is once someone starts typing a search it collapses from being menus into being a list for better visibility into search results, and keep the tab autocomplete and arrow select, and the original naming display with the /.

So normal exploration is with the nested menus (would be nice if these could also be navigated with arrow keys) and search is the flat list.

michaelsharpe commented 10 months ago

@FabriceIRANKUNDA Lets get this merged in. Could you post one final video with the added functionality with search and tab autocomplete?

FabriceIRANKUNDA commented 10 months ago

https://github.com/Oneirocom/Magick/assets/58092199/644a24f3-e604-4cd1-bf81-bd2396bbbb35