Onemind-Services-LLC / netbox-secrets

Enhance your secret management with encrypted storage and flexible, user-friendly features.
Apache License 2.0
105 stars 11 forks source link

[Bug]: Unable to Activate Selected User Keys in Admin Panel #106

Closed agusadjadj closed 1 year ago

agusadjadj commented 1 year ago

NetBox Secrets plugin version

v1.9.0

NetBox version

v3.6.4

Steps to Reproduce

Expected Behavior

The user is active after the "Activate selected user" and Go button ocurrs

Observed Behavior

Field 'id' expected a number but got ''. Seems like the checkbox has a missfunctionality

cjwagz commented 1 year ago

Receiving the same error on Plugin 1.9.0 and Netbox 3.6.4

jonnycastaway commented 1 year ago

Hello, having the same issue with Netbox Version 3.6.5 and Plugin Version 1.9.0 Is there any workaround? It's a real showstopper.

abhi1693 commented 1 year ago

I have looked into this a bit more and seems like no model on the admin side can perform bulk operations in NetBox. I'm still trying to find if this has anything to do with how NetBox is structured or an internal Django bug.

EDIT: It seems like the plugin works with NetBox v3.6.3 without any issues.

abhi1693 commented 1 year ago

The issue is caused due to https://github.com/netbox-community/netbox/compare/v3.6.3...v3.6.4#diff-310332579486e53e626dd095399f64c29fc215b386672af995b764f78328d27eR435

<input type="hidden" name="{{ widget.name }}" value="">

Either https://github.com/netbox-community/netbox/pull/13963 needs to revert or we need to figure out a way around it

agusadjadj commented 1 year ago

Thanks @abhi1693 !! Let's hope it merges to the master branch soon to implement.

And let's hope they don't play something of the style again that breaks like this

jonnycastaway commented 1 year ago

The issue is caused due to netbox-community/netbox@v3.6.3...v3.6.4#diff-310332579486e53e626dd095399f64c29fc215b386672af995b764f78328d27eR435

<input type="hidden" name="{{ widget.name }}" value="">

Either netbox-community/netbox#13963 needs to revert or we need to figure out a way around it

Good finding. Hopefully they merge or revert fast and it was not a substantial change that causes the issue.

abhi1693 commented 1 year ago

I have opened a bug report and this issue was also discussed in today's maintainers meeting. I'm going to wait a bit to see if this gets fixed in the core code otherwise will roll out this fix in the upcoming release on 4 Dec along with the NetBox beta release.

agusadjadj commented 11 months ago

Hello ! I tested the new version of Netbox (Release v3.6.7) and I can confirm that it is functional again. Let's hope it hasn't broken somewhere else!

The reference is in: https://github.com/netbox-community/netbox/issues/14392

Greetings and happy holidays !