search

Onemind-Services-LLC / netbox-secrets

Enhance your secret management with encrypted storage and flexible, user-friendly features.
Apache License 2.0
105 stars 11 forks source link

Fix copy of data in migration #72

Closed kprince28 closed 1 year ago

kprince28 commented 1 year ago

Pull Request

Description:

uedvt359 commented 1 year ago

@abhi1693, @kprince28 : i believe this commit is dangerous: if i understand the problem in bug73 correctly, you want to skip the migration for secrets on devices that were deleted. but the try-except is placed outside the for loop - when such an item is encountered, the migration is aborted silently. you will end up with items not migrated.

abhi1693 commented 1 year ago

@kprince28 Can you look into the issue again? I think the try except should be within the loop. @uedvt359 Thank you for catching this oversight.