Closed kyunghwan-onepredict closed 2 years ago
Merging #109 (b5a4b9c) into main (70a5a33) will increase coverage by
0.48%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## main #109 +/- ##
==========================================
+ Coverage 81.07% 81.56% +0.48%
==========================================
Files 24 24
Lines 560 564 +4
==========================================
+ Hits 454 460 +6
+ Misses 106 104 -2
Flag | Coverage Δ | |
---|---|---|
unittests | 81.56% <100.00%> (+0.48%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | |
---|---|---|
onebone/feature/time.py | 73.91% <100.00%> (ø) |
|
onebone/signal/smoothing.py | 79.68% <0.00%> (+4.68%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 70a5a33...b5a4b9c. Read the comment docs.
minimum 3.8은 너무 높지 않을까요?
minimum 3.8은 너무 높지 않을까요?
1.python 3.6은 공식적으로 지원이 종료되었습니다. Reference
이런 이유로 minimum 3.8로 설정하게 되었습니다. poetry dependency 문제가 python 3.7에서 해소된다면 3.7까지 허용할 생각이 있으나 현재 시점에서는 최소 버전을 3.8로 결정하였습니다.
혹시 @isingmodel 님께서도 해당 문제를 해결하는 방법을 찾게되면 알려주시기 바랍니다.
@kyunghwan-onepredict 벌써 3.6 지원 종료군요.. 말씀하신 포인트들에 동의합니다.
기범님 LGTM
Good!
Summary
Write the summary about this PR.
Changes
Write changes in detail.
How to Test?
Write a way to test the changes.
Checklist