Onepredict / onebone

An Open Source Signal Processing Library for Sensor Signals about vibration, current, etc.
MIT License
18 stars 3 forks source link

Feature/full spectrum #110

Closed ybpark-onepredict closed 1 year ago

ybpark-onepredict commented 2 years ago

Summary

Write the summary about this PR.

Changes

Write changes in detail.

How to Test?

Write a way to test the changes.

Checklist

codecov-commenter commented 2 years ago

Codecov Report

Merging #110 (913ceda) into main (84d383a) will increase coverage by 0.52%. The diff coverage is 92.85%.

@@            Coverage Diff             @@
##             main     #110      +/-   ##
==========================================
+ Coverage   81.07%   81.60%   +0.52%     
==========================================
  Files          24       24              
  Lines         560      587      +27     
==========================================
+ Hits          454      479      +25     
- Misses        106      108       +2     
Flag Coverage Δ
unittests 81.60% <92.85%> (+0.52%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
onebone/signal/fft.py 92.85% <92.59%> (-0.48%) :arrow_down:
onebone/signal/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 84d383a...913ceda. Read the comment docs.

kyunghwan-onepredict commented 2 years ago

리뷰가 많이 늦어지네요. 일단 기본적인 리뷰 남겨 두겠습니다.

kyunghwan-onepredict commented 2 years ago

PR 제목을 commit message 스타일로 변경해주세요.

Kangwhi-Kim commented 1 year ago

PR이 더이상 업데이트되지 않아 close 합니다.