search

OnetapInc / chromy

Chromy is a library for operating headless chrome. 🍺🍺🍺
MIT License
605 stars 41 forks source link

fix #29 #30

Closed ielgnaw closed 6 years ago

ielgnaw commented 6 years ago

fix #29

dotneet commented 6 years ago

Thank you for submitting PR!

I want you to change the interface a little. I hope addCustomDevice will be enabled to be used as like below:

Chromy.addCustomDevice({
  name: 'iPad',
  width: xxx,
  ...
})
or 
Chromy.addCustomDevice([{
  name: 'iPad', width: ...
}, {
  name: 'anotherCustomDevice', width: ...
}])
dotneet commented 6 years ago

@ielgnaw Thank you! I appreciate your work.

ielgnaw commented 6 years ago

@dotneet 😄