OnetapInc / chromy

Chromy is a library for operating headless chrome. 🍺🍺🍺
MIT License
605 stars 41 forks source link

Termination of Chrome process #34

Closed nicolad closed 6 years ago

nicolad commented 6 years ago

Chrome Launcher by default sets handleSIGINT to true which allow termination of chrome process on Ctrl-C. I've tried to set this flag explicit, but no result. Please advise any solution.

dotneet commented 6 years ago

Currently handleSIGINT can not be used in chromy. I'll enable this option later.

handleSIGINT is the option of .launch function of chrome-launcher. but chromy doesn't use .launch() but use Launcher class directly.

nicolad commented 6 years ago

Great, thank you, I can help you with this if you'll wish.

dotneet commented 6 years ago

Thanks! I welcome PR always.