search

Ongzl / pe

0 stars 0 forks source link

Phone number parsing overly strict #1

Open Ongzl opened 2 years ago

Ongzl commented 2 years ago

2021-11-12 (1).png

Does not accept number that does not start with 6, 8 or 9, and not 8 digits long. Overly constrained to fit into a Singapore context, where as there is no mention that this is a Singapore only app in the UG

2021-11-12 (4).png

after using ctrl+f

2021-11-12 (5).png

what if my friend that I want to add only has a foreign number? There is no ability to add his number just his tele-handle and name

nus-pe-bot commented 2 years ago

Team's Response

Firstly, this is not "A flaw that affects most users and causes major problems for users. i.e., makes the product almost unusable for most users." as per the definition of a high severity bug. If valid, it should be low severity "A flaw that is unlikely to affect normal operations of the product. Appears only in very rare situations and causes a minor inconvenience only.".

Do understand that this was a change made following feedback from the PE-D, whereas before, it followed the AB3 restrictions for phone numbers (at least 3 digits). I concede that perhaps it would be better to state in the DG/UG that the context of the product is in Singapore, however, that is not the issue here. Thus I would argue that the phone numbers are not too restrictive, rather that the tester was unclear of the context.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: UG states "desktop app for managing members in university clubs/societies" so it would seem that only Singapore has Universities and not any other country? I do not understand what the context and issue the developer team is referring to here because it seems quite straight-forward to me, phone number parsing is overly strict and narrow in a global context (confined to only Singapore). If an American tried to use this app, it would immediately be unusable.

:question: Issue severity

Team chose [severity.Low] Originally [severity.High]

Reason for disagreement: Severity would be Low if app was only to be used in countries with phone numbers that start with 6, 8, 9 and 8 digits long only, however there was no such indication in the UG/DG. App would be unusable in countries that have phone numbers that are 4, 5, 6, 7, 9, 10, 11, 12, 13 digits long and start with numbers other than 6, 8 or 9 since users would not even be able to add contacts into the app, so I would argue that it is more statistically common for the app to be used in a country that does not follow Singapore's phone number format and thus be unusable and so should be High severity.