search

OnionIoT / Onion-Docs

Documentation for all things Onion
https://docs.onion.io
GNU General Public License v3.0
112 stars 65 forks source link

For review only: PWM related changes #76

Closed chmorgan closed 5 years ago

chmorgan commented 5 years ago

Hi Lazar.

I relocated the Software PWM into a new PWM page and started to flesh it out. I took much of the blog post you created about the hardware pwm modules.

One thing I did notice is that the guide didn't provide any direction for programmatic pwm interaction, something I've had to do with a project of mine. I put in some general information to point users in the direct direction and a placeholder for an example. The example program could do the led blinking with pwm but via a Golang app. Using golang makes it easy for readers to build and deploy it, no cross compilation necessary. Would probably take an hour to put that together and test it if you were interested in having me do that.

One question I had was how to generate the bookdown final document so I could review it here in its final form. It looks like something is missing that is taking all of these sections and putting them together in the order they are presented, but I'm also not familiar with bookdown.

Can you review and provide feedback?

chmorgan commented 5 years ago

@greenbreakfast, can't seem to add you as a reviewer so mentioning you here.