Closed iammuze closed 5 months ago
Hi @greenbreakfast, it appears that a check has failed in the pull request. Could you please take a look and address any issues?
hi @iammuze, like I mentioned in my last comment in issue 28, this content should be in docs/packages/intro.md
Please make the following changes:
docs/packages/intro.md
sidebars.js
since the packages intro is already includedOh, I got confused. So, the content of this getting started guide
will be reflect similar to the Device Tree Overlays chapter, right?
Yep that’s right On Feb 7, 2024, at 12:03 PM, Muze @.***> wrote: Oh, I got confused. So, the content of this getting started guide will be reflect similar to the Device Tree Overlays chapter, right?
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>
Hi @greenbreakfast now, the content has been moved into docs/packages/intro.md
and the changes in sidebar.js
have been undone. please review it.
This pull request is automatically being deployed by Amplify Hosting (learn more).
Access this pull request here: https://pr-41.d2l2d7l06y6q7u.amplifyapp.com
The build issue was happening because the packages branch didn't have the comment section implementation. I fixed that with a rebase. Added comments to the content - please take a look
Yeah, I also set up the GiscusComment
package locally, but I didn't push it. I was thinking it might be a duplicate, but you resolved this issue. Thanks for that.
Looks good, merging these changes to main branch to publish the article
Hi, @greenbreakfast
Getting Started Guide
has been added to issue #28 , please review it.