OnionIoT / documentation

Documentation for the Omega2 beta firmware
0 stars 1 forks source link

one-wire article updated along with diagram #63

Closed iammuze closed 3 months ago

iammuze commented 4 months ago

Hi @greenbreakfast and @amsiotdeveloper,

I have updated this chapter based on the mentioned changes in issue #36.

Please have a quick review, and let me know if there are any additional changes needed.

aws-amplify-us-east-1[bot] commented 4 months ago

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-63.d2l2d7l06y6q7u.amplifyapp.com

greenbreakfast commented 3 months ago

@iammuze this looks great! Just two requests:

  1. can you please change the diagram to have a 4.7 kΩ resistor instead of the current 5.1 kΩ, so the image matches the warnings underneath it?
  2. Please remove the tip saying "Building these connections is relatively easy if you have an Expansion, Power, or Arduino Dock since they all expose the Omega’s GPIOs."
iammuze commented 3 months ago

@greenbreakfast please review the changes.

greenbreakfast commented 3 months ago

thanks