Closed remingtontr closed 1 month ago
This pull request is automatically being deployed by Amplify Hosting (learn more).
Access this pull request here: https://pr-86.d2l2d7l06y6q7u.amplifyapp.com
Yep, can do that.
Tom Remington
From: Lazar @.> Sent: May 8, 2024 7:27 AM To: OnionIoT/documentation @.> Cc: remingtontr @.>; Author @.> Subject: Re: [OnionIoT/documentation] Issue 61 completed (PR #86)
@greenbreakfast commented on this pull request.
Added 2 formatting suggestions, please take a look
In docs/hardware-interfaces/sdio.mdhttps://github.com/OnionIoT/documentation/pull/86#discussion_r1594135749:
+ + + +
- The SDIO/eMMC pins are highlighted on the Omega2S diagram below.
+
- +
+See Omega2S hardware design guide for more information and recommendations on designing boards with microSD card slots or eMMC.
What do you think about folding this into the Omega2S tab above? It only applies to the omega2s/2s+, boards that use the Omega2+ must use the microSD slot on the Omega2+ itself.
— Reply to this email directly, view it on GitHubhttps://github.com/OnionIoT/documentation/pull/86#pullrequestreview-2045843872, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A4B4PDKGK4SBZWW7WWCZ4OTZBIY4PAVCNFSM6AAAAABHLUHPJSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANBVHA2DGOBXGI. You are receiving this because you authored the thread.Message ID: @.***>
Requested changes made and pushed.
Tom Remington
From: Lazar @.> Sent: May 8, 2024 7:27 AM To: OnionIoT/documentation @.> Cc: remingtontr @.>; Author @.> Subject: Re: [OnionIoT/documentation] Issue 61 completed (PR #86)
@greenbreakfast commented on this pull request.
Added 2 formatting suggestions, please take a look
In docs/hardware-interfaces/sdio.mdhttps://github.com/OnionIoT/documentation/pull/86#discussion_r1594135749:
+ + + +
- The SDIO/eMMC pins are highlighted on the Omega2S diagram below.
+
- +
+See Omega2S hardware design guide for more information and recommendations on designing boards with microSD card slots or eMMC.
What do you think about folding this into the Omega2S tab above? It only applies to the omega2s/2s+, boards that use the Omega2+ must use the microSD slot on the Omega2+ itself.
— Reply to this email directly, view it on GitHubhttps://github.com/OnionIoT/documentation/pull/86#pullrequestreview-2045843872, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A4B4PDKGK4SBZWW7WWCZ4OTZBIY4PAVCNFSM6AAAAABHLUHPJSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANBVHA2DGOBXGI. You are receiving this because you authored the thread.Message ID: @.***>
Made a small adjustment to the bullet point list to minimize white-space Merged in
cc #61
Article for SDIO/eMMC rewritten.