search

OnionIoT / documentation

Documentation for the Omega2 beta firmware
0 stars 1 forks source link

Issue 65 completed #87

Closed remingtontr closed 1 month ago

remingtontr commented 2 months ago

Article rewritten and link to doc in sidebar removed. The DocCardList will now display all three docs in the parent folder.

aws-amplify-us-east-1[bot] commented 2 months ago

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-87.d2l2d7l06y6q7u.amplifyapp.com

remingtontr commented 1 month ago

Fixed and pushed.

Tom Remington

From: Lazar @.> Sent: May 9, 2024 11:29 AM To: OnionIoT/documentation @.> Cc: remingtontr @.>; Author @.> Subject: Re: [OnionIoT/documentation] Issue 65 completed (PR #87)

@greenbreakfast requested changes on this pull request.

Looking good, just have a few wording fixes

In docs/device-tree-overlay/intro.mdhttps://github.com/OnionIoT/documentation/pull/87#discussion_r1595824526:

+## How a Device Tree is implemented

Should be "How a Device Tree Overlay is Implemented"

In docs/device-tree-overlay/intro.mdhttps://github.com/OnionIoT/documentation/pull/87#discussion_r1595825404:

Device Trees in OpenWRT

+By default, OpenWRT supports static Device Trees in the form of Device Tree Specification (DTS) files. For example, all the DTS files for ramips-based devices can be found on GitHub's OpenWRT repository.

For the link, it would make more sense to say "OpenWRT's build system GitHub repo" instead of "GitHub's OpenWRT"

In docs/device-tree-overlay/intro.mdhttps://github.com/OnionIoT/documentation/pull/87#discussion_r1595826421:

:::

-## How to create custom Device Tree Overlay Packages +## How a Device Tree works on the device

Should be "How a Device Tree Overlay Package works on the device"

— Reply to this email directly, view it on GitHubhttps://github.com/OnionIoT/documentation/pull/87#pullrequestreview-2048568415, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A4B4PDOMIED4KGTGDEGOVETZBO6AHAVCNFSM6AAAAABHNPTX62VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANBYGU3DQNBRGU. You are receiving this because you authored the thread.Message ID: @.***>

greenbreakfast commented 1 month ago

looks good, thanks! cc #65