OnionUI / Onion

OS overhaul for Miyoo Mini and Mini+
https://onionui.github.io
GNU General Public License v3.0
3.33k stars 208 forks source link

Update mGBA core. #1104

Open twoco opened 1 year ago

twoco commented 1 year ago

Checklist

Onions OS Version

v4.2.0-RC-snapshot-a5064207

Miyoo Firmware Version

202305052130

Provide a clear and concise description of the issue

The current mGBA core 0.10-dev ec5ecb2 has an issue of flickering sprites. The commit is from Oct 25, 2022. I would test the latest version 0.10.2 2fb5545 from Apr 24, 2023. But I have no idea how to update it. Or who compiles this for the Miyoo Mini? Is this the right place here?

Steps to Reproduce

Run the game "Mario And Luigi Superstar Saga" in mGBA and see flickering sprites e.g. in the intro scene.

Provide any additional context or information that may help us investigate your issue

To fix the issue, we have to test with the latest version. Maybe this will resolve the problem or we file a bug report. Btw. I tested it with the gpSP core without that problems. Why is gpSP not in verified list?

XK9274 commented 1 year ago

Please test this:

Ignore this - mgba branch closed as there's other changes to source i wasn't aware of :)

Also just FYI, i tested just now and it didn't fix the flickering.

twoco commented 1 year ago

Yes, unfortunately it‘s not fixed. The sprites are still flickering. And moreover the game runs now in stop motion most of time. ca. 1 FPS, Unplayable (Miyoo Mini Plus). Anyway, thanks for compiling and testing too. …

TwisX commented 4 months ago

Installed Onion on my MM+ the other day and am experiencing the same issue with sprites flickering in Mario & Luigi Superstar Saga with the mGBA core. gpSP does not have this issue and seems to be running fine. I suppose it is a non-issue since gpSP works, but it would be great if this wasn't an issue with the "out of the box" Onion install. I'd be happy to help test a newer mGBA core if needed.