miyoogamelist.xml ignored in expert section (for PC-98 at least)

pig-cop commented 1 year ago

Checklist

[X] I am reporting a bug in the Onion OS - Any issues with the closed source frontend (MainUI), or RetroArch or any of the cores should be directed to their respective repositories
[X] I have reviewed the Onion Wiki and did not find the answer
[X] I have searched the existing (open and closed) issues to ensure I do not log a duplicate

Onions OS Version

4.2.0-RC

Miyoo Firmware Version

202306092122

Provide a clear and concise description of the issue

If I add a core in the expert section that by default is missing the gamelist option in the config.json and add it, the miyoogamelist.xml file will be ignored. The games will be displayed including the boxart (if it's in the /Imgs/ subfolder and properly named) but just like they display by default when miyoogamelist.xml is not used, so the filename will be used as a name in the list.

Steps to Reproduce

This is what I have done:

installed the PC-98 core (Neko Project II Kai)
edited the config.json file as this {"label":"Neko Project II Kai", "icon":"/mnt/SDCARD/Icons/Default/rapp/nekop2kai.png", "launch":"launch.sh", "rompath":"../../Roms/PCNINETYEIGHT", "imgpath":"../../Roms/PCNINETYEIGHT/Imgs", "gamelist":"../../Roms/PCNINETYEIGHT/miyoogamelist.xml", "useswap":1, "shortname":0, "hidebios":1, "extlist":"hdi" }
added a single game in the /Roms/PCNINETYEIGHT/ folder, in this case: Kono Yo no Hate de Koi o Utau Shoujo YU-NO (with Special Disk) (EN v1.01).hdi
added this miyoogamelist.xml to the /Roms/PCNINETYEIGHT/ folder: <?xml version="1.0" encoding="utf-8" standalone="yes"?><gameList><game><path>./Kono Yo no Hate de Koi o Utau Shoujo YU-NO (with Special Disk) (EN v1.01).hdi</path><name>Kono Yo no Hate de Koi o Utau Shoujo YU-NO</name><image>./Imgs/Kono Yo no Hate de Koi o Utau Shoujo YU-NO (with Special Disk) (EN v1.01).png</image></game></gameList>

After refreshing the list the game does appear but ignores the miyoogamelist.xml file. It does not use the name specified in the xml and ignores the specified image if the folder or name is different from the default one (/Imgs/.png).

Provide any additional context or information that may help us investigate your issue

For testing if I'm doing something wrong with my config.json and miyoogamelist.xml I moved the core folder from /mnt/SDCARD/RApp/nekop2kai to /mnt/SDCARD/Emu/nekop2kai and refreshed the list there, the miyoogamelist.xml is used as expected and all works like it should that way. My guess is that maybe it's a bug with the expert cores, or with PC-98 in particular?

deframe commented 1 year ago

I had the same problem with the expert Hatari core. Not only was the miyoogamelist.xml file ignored, it actually appeared in the ROMs list, as did the Imgs folder.

pig-cop commented 1 year ago

Yeah happens to the PC-98 core too. It's because the default config.json generated in the /RApp/<core_name> folder has a null value for the extension list and I guess it is assumed in this case to show all extensions. You can edit the line with "extlist" and define the correct extensions for that core.

Leemann07 commented 9 months ago

I had the same problem with the expert dosbox Pure core.

OnionUI / Onion