OnionOS 4.3 Beta: Drastic is saving multiples of .DSS save files, and causing save corruption.

laundr commented 5 months ago

Checklist

[X] I am reporting a bug in the Onion OS - Any issues with the closed source frontend (MainUI), or RetroArch or any of the cores should be directed to their respective repositories
[X] I have reviewed the Onion Docs and did not find the answer
[X] I have searched the existing (open and closed) issues to ensure I do not log a duplicate

Onions OS Version

v4.3.0-8ae761fc

Miyoo Firmware Version

202306282128

Provide a clear and concise description of the issue

Playing Pokemon Platinum on Drastic emulator on Miyoo Mini Plus.

After a few gaming sessions, the game fails to boot. It has happened twice, one of them I noticed it happened after I turned off the screen and then allowed the device to power down on its own after a 15 minute wait in sleep mode.

When starting the device the game boots to a white screen and then bounces me back to the main menu. Attempting to open the game again does the same thing.

Pulling the SD card and inspecting the save files on my computer reveals that there are 2 .DSS and one .DSV save file for the game.

The file titles are: Pokemon - Platinum Version (USA) (Rev 1).dsv Pokemon - Platinum Version (USA) (Rev 1)_0.dss Pokemon - Platinum Version (USA) (Rev 1)_10.dss

Steps to Reproduce

Start a game of pokemon platinum Save the game Single-press the power button to turn off the screen Allow the device to power itself off after the sleep period Boot the device and see if the game will run.

Provide any additional context or information that may help us investigate your issue

Upon inspecting the save files in my "NDS_OLD.7z" folder, I see that multiple saves were not created for this game. Only a single .DSS file with the title: "Pokemon - Platinum Version (USA) (Rev 1)_10.dss"

Ulquiro commented 5 months ago

I encountered this issue with all the NDS games i have tried so far, all of them with the same steps to reproduce

heydemoura commented 5 months ago

I faced the same issue with Pokemon Soul Silver, I believe it might happen to any NDS game. The workaround for me was to:

Insert the SD card on the computer and navigate to the NDS states folder. ( Saves > CurrentProfile > states > Drastic )
Rename "Game Title_10.dss" to "bkp.Game Title_10.dss"
Rename "Game Title_0.dss" to "Game Title_10.dss"

The last save I had was restored.

Maybe Drastic saves are not yet being well handled when turning off the device with sleep mode.

codsand commented 5 months ago

Yes, the save file is saving wrong from sleep. Thanks for this info, it was driving me crazy.

OnionUI / Onion