OnionUI / Onion

OS overhaul for Miyoo Mini and Mini+
https://onionui.github.io
GNU General Public License v3.0
3.16k stars 190 forks source link

"~Run Pico-8 with Splore" Does not work outside Expert Tab #1514

Closed theUnBurn closed 3 months ago

theUnBurn commented 3 months ago

Checklist

Onions OS Version

4.3.0

Miyoo Firmware Version

202303362339

Provide a clear and concise description of the issue

Pico-8 Splore Runs with the right core only when selected in the Experts tab. When attempting to access the game on the Recents or Favorites tab, it tries running the Splore png with faker-8, which it fails to do.

Steps to Reproduce

  1. Open ~Pico-8 with Splore in Experts --> Pico-8
  2. Exit the game
  3. Select it from the Recents tab

Expected:

Actual:

Provide any additional context or information that may help us investigate your issue

When viewing the core in Expert, it lists out Retro-8, but does not list it as an option when running the .png outside Expert. I wonder if we can set that to be the default core, or at least allow it to be used as a core outside the Expert tab.

I do note the docs say here that it can be run on Experts, but doesn't specify only Experts. If that is the case, I wonder if it's worth not allowing it to be Favorited or show up in Recents.

tGecko commented 3 months ago

Seems to work for me? 🤔 or am I understanding your issue wrong

https://github.com/OnionUI/Onion/assets/6023076/8c2b558c-2571-4dcd-adf0-cbda6f2e3256

theUnBurn commented 3 months ago

Hmm, I think I favorited the fake-08 version I had instead of Splore? I removed the favorite item and no longer have the issue. When I do run it from Favorites, however, I do see a Pico-8 entry in Recents that crashes, but that is unrelated to this issue and want to make sure it's repeatable before opening up another.

I think this is user error on my end, but thanks for looking into this!