[X] I am reporting a bug in the Onion OS - Any issues with the closed source frontend (MainUI), or RetroArch or any of the cores should be directed to their respective repositories
[X] I have reviewed the Onion Docs and did not find the answer
[X] I have searched the existing (open and closed) issues to ensure I do not log a duplicate
Onions OS Version
4.3.0
Miyoo Firmware Version
202310271401
Provide a clear and concise description of the issue
While working on some native Mini v4 overlays I noticed that despite the internal resolution being rendered at 752x560, and the screen shots taken while running games are taken in 752x560, that on the actual screen you cannot see the two left most columns of pixels nor the bottom row of pixels. They appear to be off screen. I've tried this on two separate Miyoo Mini v4 and found the same cropping on both.
I've attached 3 overlays that demonstrate the issue. One overlay has a single pixel wide border around it, another a 2px border and the last a 3px wide border.
Extract attached V4 test overlays into overlay folder.
Load up any RetroArch game.
Open RetroArch menu and apply the 1px border test overlay and return to game. You will see the border only on the top and right side.
Reopen RetroArch menu and apply the 2px border test overlay and return to game. You will see a thicker border on the top and right and a thinner border along the bottom.
Reopen RetroArch menu and apply the 3px border test overlay and return to game. You will see the thickest border on the top and right, thick border along the bottom and a thin border along the left.
What you should be seeing is an equal border of increasing thickness on all four sides as you apply each successive overlay.
Provide any additional context or information that may help us investigate your issue
It appears that although the V4 driver produces a 752x560 image the screen itself only has a view window of 750x559. Since the viewport and viewport offsets are set in the SDL graphics driver in the custom forked RetroArch repository we can't change the viewport settings ourselves. If this issue holds true for all V4 models and not just my two, then resX and resY will need to be adjusted to resX -= 2 and resY -= 1 along with vid->video_x = 2 and vinfo.xoffset = 2 and probably some others.
Checklist
Onions OS Version
4.3.0
Miyoo Firmware Version
202310271401
Provide a clear and concise description of the issue
While working on some native Mini v4 overlays I noticed that despite the internal resolution being rendered at 752x560, and the screen shots taken while running games are taken in 752x560, that on the actual screen you cannot see the two left most columns of pixels nor the bottom row of pixels. They appear to be off screen. I've tried this on two separate Miyoo Mini v4 and found the same cropping on both.
I've attached 3 overlays that demonstrate the issue. One overlay has a single pixel wide border around it, another a 2px border and the last a 3px wide border.
V4-Border_Test.zip
Steps to Reproduce
What you should be seeing is an equal border of increasing thickness on all four sides as you apply each successive overlay.
Provide any additional context or information that may help us investigate your issue
It appears that although the V4 driver produces a 752x560 image the screen itself only has a view window of 750x559. Since the viewport and viewport offsets are set in the SDL graphics driver in the custom forked RetroArch repository we can't change the viewport settings ourselves. If this issue holds true for all V4 models and not just my two, then resX and resY will need to be adjusted to
resX -= 2andresY -= 1along withvid->video_x = 2andvinfo.xoffset = 2and probably some others.