Scummvm scraping attempting to scrape internal game files - Githubissues

OnionUI / Onion

OS overhaul for Miyoo Mini and Mini+

https://onionui.github.io

GNU General Public License v3.0

3.16k stars 189 forks source link

Scummvm scraping attempting to scrape internal game files #1575

Open medeirosT opened 1 month ago

medeirosT commented 1 month ago

Checklist

[X] I am reporting a bug in the Onion OS - Any issues with the closed source frontend (MainUI), or RetroArch or any of the cores should be directed to their respective repositories
[X] I have reviewed the Onion Docs and did not find the answer
[X] I have searched the existing (open and closed) issues to ensure I do not log a duplicate

Onions OS Version

4.3.0

Miyoo Firmware Version

202306282128

Provide a clear and concise description of the issue

I am scraping my ScummVM games and it seems the scraping script goes through internal files as it attempts to scrape covers for these games.

Steps to Reproduce

Add new ScummVM games
Run import script
Within ScummVM game list, press Y and begin the scraping process of all games

You will see it attempting to scan internal game files to those scummvm games AS games and fail

Provide any additional context or information that may help us investigate your issue

PXL_20240506_183735711

medeirosT commented 1 month ago

I think the issue might be the maxdepth here:

https://github.com/OnionUI/Onion/blob/main/static/build/.tmp_update/script/scraper/scrap_launchbox.sh#L243

maybe add a special clause if it is a scummvm rom?