miyoogamelist tweak doesn't update titles in Favourites

fizwidget commented 6 months ago

Checklist

[X] I am reporting a bug in the Onion OS - Any issues with the closed source frontend (MainUI), or RetroArch or any of the cores should be directed to their respective repositories
[X] I have reviewed the Onion Docs and did not find the answer
[X] I have searched the existing (open and closed) issues to ensure I do not log a duplicate

Onions OS Version

4.3.0

Miyoo Firmware Version

202306282128

Provide a clear and concise description of the issue

I ran the "Generate miyoogamelist with digest names" tweak (followed by "Refresh all ROMs"). The entries in "Games" all successfully updated, but those in "Favourites" did not. I had to clear the favourites list and re-add games to see the updated/shortened titles there.

Steps to Reproduce

Add some ROMs that have things like "(USA)" at the end of their names.
Add them to your favourites list.
Run the "Generate miyoogamelist with digest names" tweak.
Refresh all ROMs.
Observe that the entires in "Games" updated, but those in "Favourites" did not.

Provide any additional context or information that may help us investigate your issue

Thanks for the awesome work on Onion! ❤️

Aemiii91 commented 6 months ago

This is not really a bug, it's just not a part of the feature 🤷‍♂️

I'll consider this a feature request.

fizwidget commented 6 months ago

Oh okay, fair point 🙂. I guess an easy improvement might be to mention this behaviour in the docs to make sure people have the right expectations.

OnionUI / Onion