New in-game menu button action: "Quick menu" + fix quitting RetroArch from arcade games

OnionUI / Onion

OS overhaul for Miyoo Mini and Mini+

https://onionui.github.io

GNU General Public License v3.0

3.46k stars 215 forks source link

New in-game menu button action: "Quick menu" + fix quitting RetroArch from arcade games #1620

Open Aemiii91 opened 5 months ago

Aemiii91 commented 5 months ago

Changes

Add option in Tweaks:
- In-game: Menu button - ... < Quick menu >
- Toggles RetroArch's quick menu
Use UDP protocol to exit RetroArch
- Fixes issues with exiting from arcade games

Try it

Test patch available here: Onion_v4.3.1-1__menu_button_UDP_actions.zip

mahoneyt944 commented 3 months ago

Does this work instead? https://github.com/libretro/RetroArch/pull/16854

mahoneyt944 commented 1 month ago

Both Quick menu and exiting games tested, works fine! Seems to fix Arcade exiting for good 👍🏻

Does https://github.com/libretro/RetroArch/pull/16854 fix this issue? This PR shouldn't be necessary if that PR is working properly within RA.

tGecko commented 1 month ago

Both Quick menu and exiting games tested, works fine! Seems to fix Arcade exiting for good 👍🏻

Does libretro/RetroArch#16854 fix this issue? This PR shouldn't be necessary if that PR is working properly within RA.

Possibly, but I don't know when we will update our RA fork. This works, is simple, and we will use the UDP commands for other things as well, like showing the RA menu, which is included in this PR

mahoneyt944 commented 1 month ago

This is certainly a case of "if it works it works", however adding to the dingux input driver for your device so that RA can read the menu button directly (or anything else for that matter) would be a much better approach than hacking the network interface in general. You could also just pull that one change into the project without updating RA entirely as well for this instance.