OnionUI / Onion

OS overhaul for Miyoo Mini and Mini+
https://onionui.github.io
GNU General Public License v3.0
3.41k stars 215 forks source link

[bug] Blue Light filter enables itself automatically #1684

Open light-and-ray opened 3 weeks ago

light-and-ray commented 3 weeks ago

Checklist

Onions OS Version

4.3.1-1

Miyoo Firmware Version

202303262339

Provide a clear and concise description of the issue

I don't enable the filter, but while I'm gaming it can enable itself, I even see this transaction. This is not connected with schedule, maybe it becomes after 30min after the device started. Every time I need to go into tweaks and disable it

Steps to Reproduce

(upd) press menu (e.g. for quick load) and B at the same time, and then hold only B

Provide any additional context or information that may help us investigate your issue

![Tweaks_001](https://github.com/user-attachments/assets/a4712962-436b-41c1-9a33-00a8e0412d07)
light-and-ray commented 3 weeks ago

there is no ignore schedule file in /tmp/. And I think it triggers every 15 minutes on the clock

Commander_Italic_000 Commander_Italic_001

light-and-ray commented 3 weeks ago

I see you only remove the file, but no where create

Screenshot_20241012_184123 Commander_Italic_003

light-and-ray commented 3 weeks ago

I.e. there is no file creation in https://github.com/OnionUI/Onion/blob/main/static/build/.tmp_update/script/blue_light.sh and https://github.com/OnionUI/Onion/blob/main/src/tweaks/actions.h

allanrps commented 3 weeks ago

Sorry I dont have assistance, but just asking how can the schedule menu option be enabled on a mini v4 with rtc?

tGecko commented 3 weeks ago

.blfIgnoreSchedule is created around here https://github.com/OnionUI/Onion/blob/58916b8bd3308853918991e5bfa25911200a72e0/src/keymon/keymon.c#L724 But I don't think it has something to do with your issue.

Is it possible that you are pressing the hotkey to enable blue light filter? It is Menu + B for 2 seconds.

Can you please enable logging in Tweaks > Advanced > Diagnostics > logging. On the next instance it happens, please create a log snapshot from the same menu, and upload it here. You will find the snapshot on the root of your SD card.

light-and-ray commented 3 weeks ago

Is it possible that you are pressing the hotkey to enable blue light filter? It is Menu + B for 2 seconds.

I didn't know about it. But nope. This hotkey is used only in NDS but I saw this bug in other games too

Maybe it is registered wrongly for example running on B in Super Mario Bros, then quick load (maybe still holding B), and then continue running, and it is registered although the menu button wasn't holded 2 seconds. I need to test it. If my clue is true, it should be fixed

BTW how to disable this hotkey? I dislike blue light filter in any form

light-and-ray commented 3 weeks ago

Yes! I can reproduce. You need to press menu+L(1or2) to quick load, and while this pressing start holding B button. And after around 2 seconds screen became dark and brown

I think the shortcut option should be next to other blue light filter options. But also the shortcut works wrongly because only B is being holded for 2 seconds

light-and-ray commented 3 weeks ago

I recommend you this ultra hardcore romhack (Super Mario Zero 2), it's very fun for playing with often quick loads, and you will face with this problem regularly https://youtu.be/Lp8IvoHd6HA 🤪

I also faced with this in other games. But so often it became in this specific game

tGecko commented 3 weeks ago

I don't know why (or how) you are pressing all these buttons at once, but we probably should provide an option to disable the hotkey 👍🏻

light-and-ray commented 3 weeks ago

It's enough to press menu and B at the same time, and then hold only B