Closed OnlineCop closed 2 years ago
Oof. Is this in addition to #116? We'd better clear the decks a bit before we start on this. (It's like one of those 10lb burger challenges where it's free if you can eat the whole lot in one go 😜 )
There were merge conflicts which I believe I have fixed. Please check!
This is not as intimidating as it first appears!
Steps:
// pal[#] ==RGB{...}
lines around so clang-format would stop mangling them. Essentially, whitespace changes only.For Step 2, whenever there was a declaration where the parameter name was missing, such as
void do_action(size_t);
, I copied the parameter name from the implementation:void do_action(size_t fighter_index);
./*unused*/
).static
definition without a declaration. I added the declaration here as well.Now comes to Step 4, the daunting one.
bounds.h
andbounds.cpp
only,combat.h
and `combat.cpp only,fade.cpp
declarations were in bothfade.h
andcompat.h
.gfx.cpp
declarations were ingfx.h
andcompat.h
.skills.h
has a duplicate declaration (also found inhskills.h
) whose definition is inhskill.cpp
, so I added comments to both places.unix.cpp
andwin.cpp
have their common declarations inplatform.h
.For all the files modified in Step 4, it was modifications to comments ONLY.
This was why I updated the parameter names in Step 2 before I started this.
static
functions, the comments were moved like everything else.private:
orprotected:
methods.And yes, I know that some of the changes were completely OCD (like adding punctuation and capitalization). The inconsistency was driving me up the wall. That just happened to be a bonus that happened while going through everything else.
Again, not as intimidating as it first appears!