Closed OnlineCop closed 2 years ago
Is this ready to go in now, @OnlineCop ? Can you see if rebasing against road_to_1.0
will get rid of all those extra historical commits, they make me nervous!
I tried rebasing with
git checkout upstream/dev/onlinecop/124_eResistance_0_based
git rebase upstream/road_to_1.0
it worked, the "res.cpp: Fill out s_item[] and s_spell[]" commit was the only one left, sitting on top of "upstream/road_to_1.0"
Alright; pushed.
The values are almost entirely the same as before (if you had been going through the values previously), but with the names eTarget::TGT_NONE
, eResitance::R_NONE
, and eEquipment::EQP_NONE
instead of the MAX_*
or TOTAL_*
names.
As far as I can tell this is OK, obviously there's no way to be 100% sure!
Changes Magic Numbers to
enum
ValuesThis builds off of #141 to address issues in #124.
enum
, that may be a bit more time-consuming.This PR may require a lot of changes to the values, so feel free to critique it heavily.