Get kq-fork running on my machine

OnlineCop / kq-fork

Fork of KQ r910. Just for fun.

GNU General Public License v2.0

15 stars 9 forks source link

Get kq-fork running on my machine #167

Closed quickdudley closed 3 months ago

quickdudley commented 4 months ago

These are the changes I made getting kq-fork to build and install on my NixOS machine, but AFAIK nothing I did is specific to NixOS.

Add a missing include statement to unix.cpp so that it compiles
Update the CMakeLists.txt directives to work with recent versions of SDL2
Install the data files to $prefix/share/kq-fork (using them from the installed location still requires passing -DKQ_DATADIR=$prefix/share/kq-fork to cmake)

OnlineCop commented 4 months ago

Thank you for this; do we know whether removing SDL2::SDL2main will have negative impacts on any other platform?

quickdudley commented 4 months ago

Fortunately I actually checked before attempting to answer your question: it seems that SDL2::SDL2main is actually still required on some platforms but no longer available on platforms on which it's not required. I will update my pull request accordingly. (CMake is actually very much a new language for me, so the first time reading the GitHub thread about that issue it seems I missed some important details from a couple of the comments)