search

OnroerendErfgoed / atramhasis

An online SKOS editor
http://atramhasis.readthedocs.io/
GNU General Public License v3.0
53 stars 11 forks source link

Fix docs: namespace missing in examples at Overriding templates section #722

Closed mielvds closed 2 years ago

mielvds commented 2 years ago

This PR fixes the example in https://atramhasis.readthedocs.io/en/latest/customisation.html#overriding-templates 

config.override_asset(
    to_override='atramhasis:templates/welcome.jinja2',
    override_with='templates/my_welcome.jinja2'
)

seems to be incomplete. The following works:

config.override_asset(
    to_override='atramhasis:templates/welcome.jinja2',
    override_with='my_thesaurus:templates/my_welcome.jinja2'
)

I also altered the dot notation to a slash to be more consistent with the above.

coveralls commented 2 years ago

Coverage Status

Coverage remained the same at 97.52% when pulling f5d9d85f916a446e68ed41b83e87083cf49cfc59 on mielvds:patch-1 into ba7e3cc68c5e32be56bdbbe1eae2f84228a62e06 on OnroerendErfgoed:develop.

koenedaele commented 2 years ago

@JonasGe Looks good to me, I checked with our thesaurus and we also add the package prefix there.