Feature/724 create and delete conceptscheme

mielvds commented 2 years ago

In light of getting familiar with the project and testing how easy it would be to contribute, a potential and partial implementation of #724. I will need some guidance on the database and UI aspects though; haven't completely figured out how the Dojo and ORM stuff works.

koenedaele commented 2 years ago

Thank you. This will end up being a big PR, so I'll have to talk to my colleagues on how structure this for development.

Sorry about the Dojo stuff, that's a really old framework. One day we'd like to completely rewrite the UI as well, but now is probably not the best time :-)

mielvds commented 2 years ago

Thank you. This will end up being a big PR, so I'll have to talk to my colleagues on how structure this for development.

I say thank you for building such an easy to work with application! Hopefully some of this is useful and please don't perceive this as pushy :)

Just some trailing thought with this PR:

the dialog for creating the scheme is very basic just to get something working; don't mind the rough input fields. I imagined the label dialog you already have instead, but it was too much work to figure out :) The whole dialog and user flow needs some decent thinking in any case.
to delete a scheme I was thinking of adding a red button in the side panel below.

Sorry about the Dojo stuff, that's a really old framework.

It's not that bad to figure out actually, reminds me of react :D They are all the same.

One day we'd like to completely rewrite the UI as well, but now is probably not the best time :-)

I cannot agree more :)

koenedaele commented 1 year ago

Closing this one as we have split this in several tickets, see #744, #745 and #774

OnroerendErfgoed / atramhasis

Feature/724 create and delete conceptscheme #725