search

OnroerendErfgoed / atramhasis

An online SKOS editor
http://atramhasis.readthedocs.io/
GNU General Public License v3.0
53 stars 11 forks source link

File to import not found when using Compass to compile SCSS files #727

Open mielvds opened 2 years ago

mielvds commented 2 years ago

Hi!

I'm getting the following errors when running compass compile in the static folder.

error scss/app-admin.scss (Line 4: File to import not found or unreadable: foundation.
error scss/app.scss (Line 4: File to import not found or unreadable: foundation.

Should https://github.com/OnroerendErfgoed/atramhasis/blob/d18c5f3f5d5ac9932287781fca6635209e8521aa/atramhasis/static/scss/app.scss#L3 be atramhasis/foundation/functions?

If I make this change, I get the same complaint for font-awesome on https://github.com/OnroerendErfgoed/atramhasis/blob/d18c5f3f5d5ac9932287781fca6635209e8521aa/atramhasis/static/scss/app.scss#L4

A side question: would it valuable to switch from compass to something like pyscss and remove the Ruby dependency and perhaps do this conversion at startup?

koenedaele commented 2 years ago

I'm going to have to pass this on to the frontend team. I think we do stuff very differently these days.

JonasGe commented 2 years ago

Hi Miel, did you run npm install before compiling the SCSS? This should install font-awesome and foundation.

In other projects, we have made the switch from NPM to yarn which can also handle the SCSS compilation.

We should look into transitioning to our more modern tech stack (python back-end, typescript/Aurelia front-end) for this application too. Or migrate the front-end to Vue.js as an experiment... @cedrikv

mielvds commented 2 years ago

Hi Miel, did you run npm install before compiling the SCSS? This should install font-awesome and foundation.

I didn't at first, but then it was complaining about https://github.com/OnroerendErfgoed/atramhasis/blob/develop/atramhasis/static/config.rb#L2

In other projects, we have made the switch from NPM to yarn which can also handle the SCSS compilation.

That fixed it acutally, thanks! Perhaps put yarn forward in the docs as well

We should look into transitioning to our more modern tech stack (python back-end, typescript/Aurelia front-end) for this application too. Or migrate the front-end to Vue.js as an experiment... @cedrikv

Compared to other open-source, java-heavy SKOS projects, I think this stack is already quite modern :D Migrating the front-end to something like Vue is probably a good idea, but not sure how big of an effort it would be. Are you considering changing the backend as well? Happy to help/brainstorm in any case.