OnroerendErfgoed / atramhasis

An online SKOS editor
http://atramhasis.readthedocs.io/
GNU General Public License v3.0
55 stars 11 forks source link

Unable to add a concept or edit a conceptscheme when there's only one provider #883

Closed koenedaele closed 4 months ago

koenedaele commented 5 months ago

Steps to reproduce:

goessebr commented 4 months ago

https://github.com/OnroerendErfgoed/atramhasis/blob/62612ef340475f110d907604bfadee3795df3f32/atramhasis/static/admin/src/app/ui/widgets/SearchPane.js#L167-L169

The activation of the buttons is triggered by an onChange event on the conceptSchemeSelect dropdown list.

Do you have a preference?

koenedaele commented 4 months ago

I was going to say that he third option woud not work if I just added a first scheme (since it would have been loaded without schemes), but I believe that a new scheme isn't automatically added to the list anyway, so a page refresh is needed always? Correct?

goessebr commented 4 months ago

Correct.

We also need to trigger a page reload or update the dropdown in the side menu after adding a provider or closing the provider addition pop-up for all options.

koenedaele commented 4 months ago

I'm fine either way, as long as it works. Go for what's easiest for frontend devs.

I assume we'll be doing a full UI update one day anyway, we can always review it then.