search

OnroerendErfgoed / atramhasis

An online SKOS editor
http://atramhasis.readthedocs.io/
GNU General Public License v3.0
55 stars 11 forks source link

Manual ID text box not writable #902

Closed DavideLicheri closed 4 months ago

DavideLicheri commented 4 months ago

Today I was able to update my atramhasis server to the 2.1.0 version. With this new release it's impossible to insert any value in the text box for the manual ID in the +Add popup for a new concept/collection, 'cause no chance to have a cursor inside...

Thanks for your help! davide

goessebr commented 4 months ago

Hi @cedrikv,

I could use some assistance with this issue.

The field in question was added in version 2.0.0, as shown in this code snippet: link. Currently, the field is disabled at all times.

Based on the code in crud.py, it appears that the provider's metadata should determine whether this field can accept manual input.

For additional context, please refer to these related issues: #732 and #740.

Could you please take a look at this?

goessebr commented 4 months ago

Oh wait, I overlooked this line of code. Dojo code isn't my strong suit.

@DavideLicheri, could you check if your provider uses a manual ID generating strategy? You can do this by opening the dialog to update the provider. image

You might want to hard refresh your browser if you recently changed this setting.

Additionally, I noticed that the dialog to create a new concept retains the IDs of previously opened concepts, which seems to be a bug.

DavideLicheri commented 4 months ago

ciao Bram, I've checked my provider. It is (as usual for me) a provider with MANUAL id generating strategy... The problem persist after a restart of the server.

...and no one ID retained opening the dialog to create a new concept/collection.

goessebr commented 4 months ago

Hi @DavideLicheri

I had to perform a hard refresh of the browser (Ctrl-F5) while this window was open. image

Reopening the window allowed me to insert my manual IDs, although I did change the ID generation strategy from numeric to manual.

Do I understand correctly that you updated from version 2.0.0 to 2.1.0 and were able to insert manual IDs while working with version 2.0.0?

DavideLicheri commented 4 months ago

“Reopening the window allowed me to insert my manual IDs”

I will try

“ updated from version 2.0.0 to 2.1.0”

Yes, with pip install atramhasis==2.1.0

“ were able to insert manual IDs”

Yes, without any problem

grazie

DavideLicheri commented 4 months ago

“Reopening the window allowed me to insert my manual IDs”

I will try

NO CHANCE with Safari on a Mac M1 with Sonoma

goessebr commented 4 months ago

We will review the issue. The manual ID generation strategy introduced in version 2.0.0 is quite inconsistent. When the ID input is enabled, other issues arise.

For reference, performing a hard refresh in Safari is slightly different, but you might have already figured that out: image

goessebr commented 4 months ago

Hi @DavideLicheri, The new atramhasis 2.1.1 is now available with a fix for this issue. It is now possible add your own ID. You might still need a hard browser refresh though.