Closed goessebr closed 1 month ago
Question: Do we want to keep these external providers in our demo?
Just for the record: yes, we do want these external providers in our demo as it demonstrates some of the very powerful features we have with loading and merging external concepts.
This works in skosprovider < 6 because the default RDF format in RDFlib is RDF/xml there. As of RDFlib 6, the default format is turtle, so https://github.com/OnroerendErfgoed/skosprovider_getty/blob/develop/skosprovider_getty/utils.py#L303 tries to parse RDF/xml as turtle, which does not work. Best solution would be to make the format explicit when parsing. It's also rather weird that we set the format to rdf outside of the uri_to_graph function. I would suggest passing in an actual uri (no extension) and letting the function add the extension. Right now we have a function that looks like it can be used with all kinds of formats, while actually it only functions with a .rdf file.
Basic solution, get skosprovider_getty working with RDFlib >= 6 first.
The cookiecutter code was integrated in atramhasis since release 2.1.0: https://github.com/OnroerendErfgoed/atramhasis/releases/tag/2.1.0
Documentation can be found at:
Admin section
I start the application and go to http://0.0.0.0:6543/admin
Following error appears:
Log:
Commenting the getty providers fixes the admin interface.
We need to remove them or fix loading them. Fixing them might require a change in https://github.com/OnroerendErfgoed/skosprovider_getty
Downgrading rdflib to 5.0.0 fixes the issue also (current version is 6.1.1), we need to take a look at https://rdflib.readthedocs.io/en/stable/upgrade5to6.html
Public section
Directly adressing a getty thesauri raises an Exception as well. For exemple http://0.0.0.0:6543/conceptschemes/AAT