search

OnroerendErfgoed / skosprovider_atramhasis

A skosprovider that can talk to an Atramhasis instance
http://skosprovider-atramhasis.readthedocs.org
MIT License
2 stars 0 forks source link

Develop #119

Closed goessebr closed 2 years ago

coveralls commented 2 years ago

Coverage Status

Coverage decreased (-0.0%) to 99.111% when pulling fa0e22e3e703fd00a553ff8264d6ff64c6206e79 on develop into aa894ec59749e520699eb4e69668fe4fd7ab7163 on master.

goessebr commented 2 years ago

Coverage Status

Coverage decreased (-0.0%) to 99.111% when pulling 1792b49 on develop into aa894ec on master.

-0,0% is not a decrease.

The code in https://github.com/OnroerendErfgoed/skosprovider_atramhasis/blob/a4f976295fbae783dafdab31c56d7774dc4dc99c/skosprovider_atramhasis/providers.py#L266-L267 is probably obsolete. A response object seems to get a default encoding of utf-8 if no charset is given.

The test test_request_encoding does not trigger the if-statement above https://github.com/OnroerendErfgoed/skosprovider_atramhasis/blob/4ef0b1cdb89522c35e61ec97b7ab8b56d397e333/tests/test_providers.py#L481-L485