Maybe consider removing the cache on provider.get_by_uri

OnroerendErfgoed / skosprovider_atramhasis

A skosprovider that can talk to an Atramhasis instance

http://skosprovider-atramhasis.readthedocs.org

MIT License

2 stars 0 forks source link

Maybe consider removing the cache on provider.get_by_uri #89

Closed Wim-De-Clercq closed 4 years ago

Wim-De-Clercq commented 4 years ago

Because def get_by_uri calls def get_by_id internally, you end up with double cache entries, 1 for each method when calling get_by_uri. Maybe it's not worth to have a cache decorator on the get_by_uri and save on caching memory/disk space?

https://github.com/OnroerendErfgoed/skosprovider_atramhasis/blob/905630b7c35c2c80381ea41f8337268df13f0c5b/skosprovider_atramhasis/providers.py#L115-L133

Wim-De-Clercq commented 4 years ago

Ah, ik had over de self._request binnen get_by_uri gekeken. Dat is waarschijnlijk een slecht plan dan.