Querying for documents requires a data source

Onto-Med / top-api

REST API of the TOP Framework

https://onto-med.github.io/top-api/

MIT License

0 stars 1 forks source link

Querying for documents requires a data source #171

Closed ChristophB closed 4 months ago

ChristophB commented 4 months ago

There are currently some operations that request documents without specifying the data source to be used. As we want to support multiple data sources, the source ID needs to be added as an additional parameter.

fmatthies commented 4 months ago

We also want to squash the different endpoints into one -> path params will become query param.

fmatthies commented 4 months ago

There are now only three document endpoints:

one general where one gets paged documents (requires document data source)
one that requests a particular document (requires document data source)
one that gets documents from a specific query (does not require document data source, since that information is inside a query)

Do you think that this suffices, @ChristophB ?

I will refactor the other endpoints (phrase and conceptcluster) as well, where applicable

ChristophB commented 4 months ago

Do you think that this suffices, @ChristophB ?

This is looking good!

ChristophB commented 4 months ago

~~I am wondering one thing. If you distinguish between searching for documents with and without a query, will we be able to search in a cluster with phrases etc?~~

Edit: Never mind, just had a look at your commit.

fmatthies commented 4 months ago

I close this issue now and create a pull request. The refactoring of the other endpoints will be done within another branch.