search

Onto-Med / top-backend

Spring Boot based backend of the TOP Framework
MIT License
0 stars 1 forks source link

Move CSVConverter #160

Closed fmatthies closed 1 year ago

fmatthies commented 1 year ago

Is there a way we could move all the CSV logic into top-backend and abstract it? Right now I'm duplicating most of the code from top-phenotypic-query in top-document-query, because I want to provide some ability to store/save document query info.

ChristophB commented 1 year ago

I think we cannot create abstract classes/interfaces in top-backend, as this would lead to circular references.

AlexU75 commented 1 year ago

Do you want to save the query specification as CSV, not as JSON?

fmatthies commented 1 year ago

I think we cannot create abstract classes/interfaces in top-backend, as this would lead to circular references.

I figured; so the only option (if we wanted to pull it out either way), would be to make it into a separate package...

fmatthies commented 1 year ago

Do you want to save the query specification as CSV, not as JSON?

Hm, I thought the metadata information would be feasible to have as csv as well.

AlexU75 commented 1 year ago

Okay, then we'll have to outsource it.

fmatthies commented 1 year ago

we agreed on not outsourcing it; top-document-query features its own csv classes