search

OntoUML / ontouml-models

The OntoUML/UFO Catalog is a collaborative, structured and open-source catalog of OntoUML and UFO ontology models.
https://w3id.org/ontouml-models/
Other
42 stars 44 forks source link

Diagram file names out of defined standard #93

Closed pedropaulofb closed 2 years ago

pedropaulofb commented 2 years ago

Some work folders have diagram file names that are different than the currently defined standard, which is diagramX.png (X is its number).

tgoprince commented 2 years ago

The convention for naming diagrams is:

new diagrams/: a folder containing figures of all diagrams redrawn on Visual Paradigm (keeping matching names with original ones); you should not use this folder if you have the original ontology in Visual Paradigm already, as it is intended only for ontologies that are being manually replicated

diagram1, diagram2, etc were just names given in the example.

it is in fact beneficial to have actual diagram names, as we know the intention behind it.

pedropaulofb commented 2 years ago

In this case, please discard the commit bc1fae97901ee0914bff1d4048a7e8ea4c891d11, named "Diagrams files renamed".

In the cited commit I had changed the names of some diagrams for the generic names.

I'm so sorry about that.

tgoprince commented 2 years ago

I just checked this commit.

I saw that you renamed filed called diagram_1.png to diagram1.png.

These changes did not make us lose any information. So, we don't need to revert them.

To avoid misinterpretations like this in future submissions, I adjusted the instructions on the wiki: https://github.com/unibz-core/ontouml-models/wiki/How-to-Contribute

Please verify.