search

OntologyAlignmentProject / ontology

Open-source repository for Ontology Alignment Project
Apache License 2.0
15 stars 9 forks source link

add waste class #5

Closed TristanWebber closed 8 months ago

TristanWebber commented 1 year ago

Adding some equipment and points for waste and bins. These have been used in a RTLS (real time location system) project tracking the movement and state of bins throughout a large facility. This should be considered a starting point and is likely to be significantly refined if adapted by other use cases.

The PR has been coordinated through a working group as a colab between OAP and AIRAH.

annieDehghani commented 11 months ago

@TristanWebber this is a great start! I made a few comments on your PR. Any new tags (such as waste, weight, location, etc.) will also need to be added to data/type-tags.yaml

TristanWebber commented 10 months ago

Thanks Annie. Apologies it took me a while to get to this. I have accepted your changes and made others as suggested. Some notes are:

  1. for type-tags.yaml, anything I added included the source as OAP. Is this appropriate?
  2. do the attribute tags, eg volume and wasteType belong in attr.yaml?
annieDehghani commented 10 months ago

@TristanWebber. looks good!

  1. Yes, OAP should be the source.
  2. Yes, I would suggest adding volume and wasteType as attributes in attr.yaml.
TristanWebber commented 10 months ago

Thanks @annieDehghani. I have now added the attributes. I renamed the volume attribute to containerVolume to reduce risk of ambiguity with the unit tag of the same name. Hopefully this allows it to be used generically as required.

Please let me know if there are any other changes required.