search

Onyx-Protocol / Onyx

Onyx
https://Onyx.org
GNU Affero General Public License v3.0
1.79k stars 362 forks source link

dashboard: generate licenses during production builds #1424

Closed jeffomatic closed 7 years ago

jeffomatic commented 7 years ago

This commit adds license-webpack-plugin to the dashboard build pipeline. A new file, 3rdpartylicenses.txt, will be generated in our production webpack bundle. The primary use case for this file is to as the basis for a more accurate NOTICE file in our dashboard source directory, one that only includes licenses for dependencies that we are actually re-distributing.

jeffomatic commented 7 years ago

PTAL @danrobinson @dominic

dominic commented 7 years ago

@jeffomatic Do we need to write this to NOTICE, or is that just a manual step when releasing?

jeffomatic commented 7 years ago

We need to combine the output from this step with a manual cut/paste job that includes the Facebook patent grant, and then commit that to NOTICE.

dominic commented 7 years ago

Okay cool :+1:

The 3rdpartylicenses.txt file will get bundled into generated/dashboard.go here. Is that okay? It only adds 70KB, but is still extra noise.

jeffomatic commented 7 years ago

The 3rdpartylicenses.txt file will get bundled into generated/dashboard.go here. Is that okay? It only adds 70KB, but is still extra noise.

I pushed a commit that removes it from the bundle.

dominic commented 7 years ago

@jeffomatic LGTM

danrobinson commented 7 years ago

LGTM thanks Jeff!