errors: lazily load stack trace info

Onyx-Protocol / Onyx

Onyx

https://Onyx.org

GNU Affero General Public License v3.0

1.79k stars 362 forks source link

errors: lazily load stack trace info #1457

Closed kr closed 7 years ago

kr commented 7 years ago

The standard library now provides a more convenient and robust way to get stack frame information, that correctly handles panic frames and non-Go (e.g. cgo) frames. At the same time, we can save some allocations and CPU time while capturing a stack trace by storing just the "callers" slice of PC values as returned by runtime.Callers.

kr commented 7 years ago

PTAL

jbowens commented 7 years ago

👀

jbowens commented 7 years ago

lgtm