Onyx-Protocol / Onyx

Onyx
https://Onyx.org
GNU Affero General Public License v3.0
1.79k stars 362 forks source link

Allow overriding AWS S3 Region with env var #1471

Closed harlow closed 6 years ago

harlow commented 6 years ago

Previously the S3 connection was initialized as the global variable before env.Parse() was called.

By moving the initialization into the main func we can leverage the env helper functions.

Addresses:

region = "us-east-1" // TODO(kr): figure out how to not hard code this

From commit: https://github.com/chain/chain/commit/aca1da719fc31f34df9a96c20ef3715a9e3493d4

CLAassistant commented 6 years ago

CLA assistant check
All committers have signed the CLA.

harlow commented 6 years ago

cc @kr lemme know your thoughts