search

Onyx-Protocol / Onyx

Onyx
https://Onyx.org
GNU Affero General Public License v3.0
1.79k stars 362 forks source link

don't compile protoc #890

Closed kr closed 7 years ago

kr commented 7 years ago

Our docker image for CI is compiling protoc from source, which takes an ungodly amount of time. But they have binary releases we can download.

https://github.com/google/protobuf/releases

Let's look in to that.

kr commented 7 years ago

One possible reason: maybe they don't run on CentOS 6 (glibc 2.12).

boymanjor commented 7 years ago

The official protobuf binaries are built with an incompatible version of glibc. What do you think of pulling the compiled binary out of the image and throwing it up on s3? We can add downloading it as a part of the image build.

bobg commented 7 years ago

Worth mentioning: although generated Go code in proto3 is not supposed to contain getters for simple scalar fields (as documented here), a recent change to protoc re-added them. The resulting difference between go generate output on my computer vs. that on Wercker had me briefly confounded.

Whichever version of protoc we settle on for CI, let's make sure it's the same one we use for development.

boymanjor commented 7 years ago

Fixed by #893