Crashing when used with Roughly Enough Items

OnyxStudios / Refined-Machinery

A tech mod with machines and stuff for 1.14

https://minecraft.curseforge.com/projects/320491

15 stars 6 forks source link

Crashing when used with Roughly Enough Items #47

Closed BurgerLUA closed 5 years ago

BurgerLUA commented 5 years ago

Upon clicking dust in any recipe with Roughly Enough Items , the client crashes with log error

Description: mouseClicked event handler

java.lang.ClassCastException: abused_master.refinedmachinery.registry.PulverizerRecipes$PulverizerRecipe cannot be cast to net.minecraft.class_1860

Log: https://paste.ee/p/MbfXP

It happens with no other craftable object, only the dust.

shedaniel commented 5 years ago

Duplicate of #40 and #42 and apparently REI didn't fix this correctly (REI should be able to catch the error, print the track trace and not crash), and I forgot to claim in REI that if the recipe type doesn't extend Recipe<?>, these lines should return an empty optional (https://github.com/shedaniel/RoughlyEnoughItems/blob/5e9a5691c42b535eb9bb410fe366edfbae93192d/src/main/java/me/shedaniel/rei/api/RecipeDisplay.java#L18-L21).

robmctouche commented 5 years ago

How would i fix this issue >?

UpcraftLP commented 5 years ago

How would i fix this issue >?

by updating your REI version.