OnyxXIII / New-Terrodim-Origins

A group of Origins for the Minecraft Origins mod, defined and used by the players on the New Terrodim Minecraft Server
0 stars 0 forks source link

Loot Table Changes Conflict with Other Datapacks #20

Closed OnyxXIII closed 9 months ago

OnyxXIII commented 10 months ago

Describe the bug Loot tables added in Origin powers conflict catastrophically with other datapacks' loot tables (in this case, the VanillaTweaks MoreMobHeads datapack) Mostly, this means the affected mobs drop nothing. However, if slain with a thrown trident, the affected mob crashes the server.

To Reproduce Steps to reproduce the behavior:

  1. Using an origin with a loot table power, kill a mob
  2. Note the lack of drops

Expected behavior Game should roll for drops from origin loot table, then check the heads loot table.

Developer notes I'm not sure if it's possible to convince the game to check each table in succession. If not, it may be possible to tell the origin power to ignore the moremobheads table, then add the heads to the origin's table Worst case, we can add heads to everyone's custom loot table.

Worth testing: All the loot tables that have this issue so far have referenced the minecraft loot table but rolled multiple times. What if we recreated our own loot table that didn't make any references outside? Would it still crash? Would it roll on the head table?

OnyxXIII commented 10 months ago

2 and #17 are examples of this issue

OnyxXIII commented 9 months ago

Fixed in next update