search

OoTRandomizer / OoT-Randomizer

A randomizer for Ocarina of Time.
Other
405 stars 233 forks source link

Respect system light/dark theme #1380

Open fenhl opened 3 years ago

fenhl commented 3 years ago

When launching the 6.0 GUI, or the web generator, it always appears in a rather bright color scheme. It would be better for it to check whether the system is in dark mode and use a darker theme in that case. In CSS, this is usually done with a @media (prefers-color-scheme: dark) block, though I don't know if it works the same way with Node and Angular.

Nicholas-Steel commented 3 years ago

Also include a way to manually specify a theme.

TreZc0 commented 3 years ago

The theme option was stripped from the gui, mostly for space reasons. With the amount of custom elements and the crapton of css, having multiple themes will be quite the effort. Can be done of course, just not a quick change. Given that the gui is not insanely bright, I do think it's something for the nice 2 have list.

fenhl commented 2 years ago

Maybe as a quick fix, a dark theme could be added to the website itself? The background color is #f5f5f5. That's basically white.

TreZc0 commented 2 years ago

I definitely need to look into that - sadly not particularly good at dark color themes, but will try with a bit of time.

fenhl commented 9 months ago

The generator itself now follows the system theme, but the rest of the website now always uses a dark theme. Having a light theme is just as important. For example, I use dark themes sometimes because of migraines, but light themes otherwise because of a visual impairment that makes light text on dark backgrounds difficult to read.