OoTRandomizer / OoT-Randomizer

A randomizer for Ocarina of Time.
Other
404 stars 233 forks source link

Excluding "Rupee Tower" freestanding rupee items doesn't work as expected #1895

Open Prelle opened 1 year ago

Prelle commented 1 year ago

When shuffling freestanding rupees, if you exclude any location which is the first for a given set of "Rupee Tower" rupees, it will break replacements for any of the other items in that set.

For example, if you add KF Bean Platform Green Rupee 1 to the list of Excluded Locations, but leave the remaining items in (KF Bean Platform Green Rupee 2-6, KF Bean Platform Red Rupee), those items will still appear as their normal vanilla items during play.

Note that the included items DO get shuffled, which means a critical item could be impossible to obtain if it lands in an included spot that is broken because of this bug.

image image (in this example, all of the green rupees are in the excluded list, which is why they get shuffled to random junk items. The red rupee should NOT be excluded, but was not replaced with a Deku Shield as expected)

Prelle commented 1 year ago

FWIW, the behavior of excluded items being force-replaced with random junk items (even if the excluded item was already a junk item, like a freestanding green rupee), was not intuitive to me. I expected the green rupees to all be "shuffled" as "Rupee (1)" in the JSON, or to be omitted entirely and left with their vanilla item. The intent was that only the red rupees in the middle would be eligible to be replaced with important items.

Prelle commented 1 year ago

More info on this bug from Discord: image image image image

fenhl commented 1 year ago

This is caused by #1813. One more reason to change that behavior.