search

OoTRandomizer / OoT-Randomizer

A randomizer for Ocarina of Time.
Other
403 stars 233 forks source link

Missing visual effect from ice traps in most chests #1912

Open fenhl opened 1 year ago

fenhl commented 1 year ago

If an ice trap is in a chest which is also an ice trap in vanilla, you can clearly see a visual frost effect. If an ice trap is in a different chest, this effect is missing.

GSKirox commented 1 year ago

So i was looking at the chest decomp for an unrelated reason, and i noticed something related to this : https://github.com/zeldaret/oot/blob/master/src/code/z_effect_soft_sprite_old_init.c#L1166 says it needs OBJECT_FZ to be loaded on the scene, which is related to the Freezards enemies.

So i did a quick test and indeed, if you put an ice trap in a chest in a room where there are Freezards like Water Trial for example, the effect does work ! So maybe a way to make this work would be to somehow load this object on the scene when an ice trap is in the chest.

fenhl commented 5 months ago

The PR fixing this was reverted, see #2210 for the reason. Any future attempt at fixing this should ensure that crash is avoided. @rrealmuto has mentioned that there is such a fix on the boulder shuffle branch.