Revert fix for icy smoke effect in chests with an ice trap

[GSKirox]

The fix proposed in #2169 for issue #1912 does lead to crashes in some cases, as concluded by the discussion here : https://discord.com/channels/274180765816848384/438698093354156032/1233927513949081682

The best solution would involve an heavy rework of the object loading system, which could be potentially PR'd by Rob for later features, so in the mean time it's probably best to just revert and re-open the issue since it's not a critical one.

[fenhl]

Do you have a plando that can be used to test this? I'm reading the linked conversation trying to figure out what exactly crashed when.

[fenhl]

Okay, here we go. To reproduce, use the following plando and go from the GTG lava room to the maze using Song of Time.

{
    "settings": {
        "open_forest": "open",
        "starting_age": "adult",
        "spawn_positions": ["adult"],
        "gerudo_fortress": "open",
        "start_with_rupees": true,
        "logic_rules": "none",
        "shuffle_smallkeys": "keysanity",
        "shuffle_silver_rupees": "anywhere",
        "starting_items": {
            "Ocarina": 1,
            "Song of Time": 1,
            "Bomb Bag": 1,
            "Small Key Ring (Gerudo Training Ground)": 1,
            "Hylian Shield": 1
        },
        "starting_hearts": 20
    },
    "entrances": {
        "Adult Spawn -> Temple of Time": "Gerudo Fortress"
    },
    "locations": {
        "Gerudo Training Ground Lobby Left Chest":                           {"item": "Ice Trap", "model": "Bombchus (20)"},
        "Gerudo Training Ground Lobby Right Chest":                          "Bombs (5)",
        "Gerudo Training Ground Stalfos Chest":                              "Gold Skulltula Token",
        "Gerudo Training Ground Before Heavy Block Chest":                   "Bombs (5)",
        "Gerudo Training Ground Heavy Block First Chest":                    "Gold Skulltula Token",
        "Gerudo Training Ground Heavy Block Second Chest":                   "Deku Nuts (5)",
        "Gerudo Training Ground Heavy Block Third Chest":                    "Deku Seeds (30)",
        "Gerudo Training Ground Heavy Block Fourth Chest":                   "Bombs (5)",
        "Gerudo Training Ground Eye Statue Chest":                           "Arrows (10)",
        "Gerudo Training Ground Near Scarecrow Chest":                       "Arrows (5)",
        "Gerudo Training Ground Hammer Room Clear Chest":                    "Rupees (5)",
        "Gerudo Training Ground Hammer Room Switch Chest":                   "Rupees (50)",
        "Gerudo Training Ground Freestanding Key":                           "Deku Seeds (30)",
        "Gerudo Training Ground Maze Right Central Chest":                   "Arrows (5)",
        "Gerudo Training Ground Maze Right Side Chest":                      "Bombs (5)",
        "Gerudo Training Ground Underwater Silver Rupee Chest":              "Silver Rupee (Bottom of the Well Basement)",
        "Gerudo Training Ground Beamos Chest":                               "Piece of Heart",
        "Gerudo Training Ground Hidden Ceiling Chest":                       {"item": "Ice Trap", "model": "Silver Rupee (Bottom of the Well Basement)"},
        "Gerudo Training Ground Maze Path First Chest":                      "Arrows (10)",
        "Gerudo Training Ground Maze Path Second Chest":                     "Deku Shield",
        "Gerudo Training Ground Maze Path Third Chest":                      "Gerudo Membership Card",
        "Gerudo Training Ground Maze Path Final Chest":                      "Small Key (Forest Temple)",
        "Gerudo Training Ground Lava Room Silver Rupee Front Left":          "Small Key Ring (Thieves Hideout)",
        "Gerudo Training Ground Lava Room Silver Rupee Front Right":         {"item": "Ice Trap", "model": "Silver Rupee (Ganons Castle Forest Trial)"},
        "Gerudo Training Ground Lava Room Silver Rupee Flame Circle":        "Rupees (20)",
        "Gerudo Training Ground Lava Room Silver Rupee Center Right":        "Compass (Deku Tree)",
        "Gerudo Training Ground Lava Room Silver Rupee Hookshot Target":     "Rupees (5)",
        "Gerudo Training Ground Underwater Silver Rupee Top":                "Gold Skulltula Token",
        "Gerudo Training Ground Underwater Silver Rupee Middle":             "Gold Skulltula Token",
        "Gerudo Training Ground Underwater Silver Rupee Bottom Front Right": "Silver Rupee (Ganons Castle Forest Trial)",
        "Gerudo Training Ground Underwater Silver Rupee Bottom Center":      "Silver Rupee (Ganons Castle Forest Trial)",
        "Gerudo Training Ground Underwater Silver Rupee Bottom Back Left":   "Gold Skulltula Token",
        "Gerudo Training Ground Boulder Room Silver Rupee Bottom Right":     "Rupees (5)",
        "Gerudo Training Ground Boulder Room Silver Rupee Bottom Left":      "Gold Skulltula Token",
        "Gerudo Training Ground Boulder Room Silver Rupee Ceiling":          "Arrows (10)",
        "Gerudo Training Ground Boulder Room Silver Rupee Ledge":            "Arrows (30)",
        "Gerudo Training Ground Boulder Room Silver Rupee Top Left":         "Bombs (10)"
    }
}