OoTRandomizer / OoT-Randomizer

A randomizer for Ocarina of Time.
Other
397 stars 230 forks source link

New Item : Bronze scale #2224

Open GSKirox opened 1 month ago

GSKirox commented 1 month ago

Inspired by SoH's implementation.

This draft PR requires some help for logic and testing in general. All help appreciated !

This adds a new first progressive scale in the item pool : the bronze scale. Until the player finds it, Link will automatically respawn if he goes fully in water, unless Iron Boots are put on. The respawn will be at the last entrance, unless that entrance is underwater. All of these have been special cased to have a respawn nearby on a safe place to avoid softlocks.

Water Temple has two special cases :

The respawns don't lose any health, to make it play nice with high damage multiplier setting.

On the UI side, i added a 0 on the scale on the file select screen if the bronze scale setting is on and the player has no scale. This would maybe also need a marker in the equipment pause screen. Not sure.

Logic has been implemented as best as i could, but that's the part where this PR needs the most help with.

fenhl commented 1 month ago

Please move the new item to get item ID 0x0130 to avoid conflicts with the other open PRs marked “Changes Item Table” (other than per-world settings, which I still need to rebase and adjust for that, so I'll use 0x0131 and following for it). This will allow testing this PR together with (some of) the others on a fork.

GSKirox commented 1 month ago

Done 👍

ktspeedruns commented 1 month ago

Instead of making an exception for Water Temple entrance, why not move the spawn point so you wouldn't be in the water, and also change the IDs of the polygons at the edge going up the exit so you don't even need to go into the water to exit Water Temple? Or, maybe even add Ruto at the beginning, and if you talk to Ruto she asks "Do you want to leave the temple?" and if you say yes, you spawn outside the Temple (or on Lake Hylia warp pad if it would put you in Lake Hylia)?

GSKirox commented 1 month ago

I'd rather not modify the game scenes directly, i feel like that should be a last resort solution. Also this is a lot more complex hacking, while the current exception is just a single line of code.

Pepe20129 commented 3 weeks ago

Hi! I'm the one that made this for Ship. 2 things: