OoTRandomizer / OoT-Randomizer

A randomizer for Ocarina of Time.
Other
404 stars 233 forks source link

Fix custom song name display enabled when it should not be #2264

Closed GSKirox closed 4 months ago

GSKirox commented 4 months ago

During the development of #2147, a change was made to always fill the array containing the song names instead of only when the setting is enabled, but this change was not reflected correctly in the C function that is supposed to check if the setting was enabled. Since it relied on an array that was now always non-empty, the names were always displayed.

This role is now passed to the CFG_SONG_NAME_POSITION variable, renamed to CFG_SONG_NAME_STATE to better display its purpose : 0 for no display, 1 for every music change, 2 for pause screen only.